[llvm-commits] [llvm] r147978 - /llvm/trunk/lib/Analysis/LazyValueInfo.cpp

Owen Anderson resistor at mac.com
Wed Jan 11 15:31:12 PST 2012


Are you confident this is safe?  I recall attempting to make this change once in the past and running into tons of iterator invalidation problems.

--Owen

On Jan 11, 2012, at 2:57 PM, Bill Wendling wrote:

> Author: void
> Date: Wed Jan 11 16:57:32 2012
> New Revision: 147978
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=147978&view=rev
> Log:
> Use a DenseMap.
> 
> This appears to improve sqlite3's compile time by ~2%.
> 
> Modified:
>    llvm/trunk/lib/Analysis/LazyValueInfo.cpp
> 
> Modified: llvm/trunk/lib/Analysis/LazyValueInfo.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/LazyValueInfo.cpp?rev=147978&r1=147977&r2=147978&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Analysis/LazyValueInfo.cpp (original)
> +++ llvm/trunk/lib/Analysis/LazyValueInfo.cpp Wed Jan 11 16:57:32 2012
> @@ -29,7 +29,6 @@
> #include "llvm/ADT/DenseMap.h"
> #include "llvm/ADT/DenseSet.h"
> #include "llvm/ADT/STLExtras.h"
> -#include <map>
> #include <stack>
> using namespace llvm;
> 
> @@ -360,7 +359,7 @@
>     /// ValueCacheEntryTy - This is all of the cached block information for
>     /// exactly one Value*.  The entries are sorted by the BasicBlock* of the
>     /// entries, allowing us to do a lookup with a binary search.
> -    typedef std::map<AssertingVH<BasicBlock>, LVILatticeVal> ValueCacheEntryTy;
> +    typedef DenseMap<AssertingVH<BasicBlock>, LVILatticeVal> ValueCacheEntryTy;
> 
>     /// ValueCache - This is all of the cached information for all values,
>     /// mapped from Value* to key information.
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list