[llvm-commits] Removing redundant default cases

David Blaikie dblaikie at gmail.com
Tue Jan 10 00:26:26 PST 2012


<bump>

On Mon, Dec 19, 2011 at 6:16 PM, David Blaikie <dblaikie at gmail.com> wrote:
> [reattached the patch (sorry I didn't attach it in the bump - didn't
> want to fill people's mailboxes with duplicates, but I realize the
> original mail might've been so old as to have dropped out of people's
> caches) - right this second I don't have a moment to update it so this
> may or may not apply cleanly to ToT - I'll update again when I have a
> moment to do that and possibly to reapply my clang hack to see if any
> new violations have been introduced]
>
> - David
>
> On Mon, Dec 19, 2011 at 5:11 PM, Chris Lattner <clattner at apple.com> wrote:
>> Hi David,
>>
>> Can you repost the patch?  The general idea of the patch seems sound.
>>
>> -Chris
>>
>> On Dec 14, 2011, at 12:05 PM, David Blaikie wrote:
>>
>>> Bump - any interest? (this may be a bit outdated, I can resurrect &
>>> update it if desired)
>>>
>>> On Fri, Sep 23, 2011 at 7:22 PM, David Blaikie <dblaikie at gmail.com> wrote:
>>>> A similar patch for one I've just sent out for clang - removing any default
>>>> cases in a switch that already has all the enum values specified (only for
>>>> switches over enums).
>>>>
>>>> I don't know whether this stylistic/coding convention is consistent between
>>>> llvm and clang, so thought I'd ask first. Ideally once we get a good warning
>>>> for this in clang we could turn it on by default.
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: llvm_excess_default_fixes.diff
Type: text/x-diff
Size: 34056 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120110/de5f4b84/attachment.diff>


More information about the llvm-commits mailing list