[llvm-commits] [llvm] r147802 - /llvm/trunk/utils/TableGen/AsmMatcherEmitter.cpp

Devang Patel dpatel at apple.com
Mon Jan 9 13:30:46 PST 2012


Author: dpatel
Date: Mon Jan  9 15:30:46 2012
New Revision: 147802

URL: http://llvm.org/viewvc/llvm-project?rev=147802&view=rev
Log:
Use descriptive variable name and remove incorrect operand number check.

Modified:
    llvm/trunk/utils/TableGen/AsmMatcherEmitter.cpp

Modified: llvm/trunk/utils/TableGen/AsmMatcherEmitter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/AsmMatcherEmitter.cpp?rev=147802&r1=147801&r2=147802&view=diff
==============================================================================
--- llvm/trunk/utils/TableGen/AsmMatcherEmitter.cpp (original)
+++ llvm/trunk/utils/TableGen/AsmMatcherEmitter.cpp Mon Jan  9 15:30:46 2012
@@ -806,20 +806,17 @@
   return true;
 }
 
-/// extractSingletonRegisterForAsmOperand - Extract singleton register, if present,
-/// from specified token.
+/// extractSingletonRegisterForAsmOperand - Extract singleton register, 
+/// if present, from specified token.
 void MatchableInfo::
-extractSingletonRegisterForAsmOperand(unsigned i, const AsmMatcherInfo &Info,
+extractSingletonRegisterForAsmOperand(unsigned OperandNo, 
+                                      const AsmMatcherInfo &Info,
 				      std::string &RegisterPrefix) {
-  StringRef Tok = AsmOperands[i].Token;
+  StringRef Tok = AsmOperands[OperandNo].Token;
   if (RegisterPrefix.empty()) {
-    if (i) {
-      std::string LoweredTok = Tok.lower();
-      if (const CodeGenRegister *Reg = Info.Target.getRegisterByName(LoweredTok))
-	AsmOperands[i].SingletonReg = Reg->TheDef;
-    } else
-      if (const CodeGenRegister *Reg = Info.Target.getRegisterByName(Tok))
-	AsmOperands[i].SingletonReg = Reg->TheDef;
+    std::string LoweredTok = Tok.lower();
+    if (const CodeGenRegister *Reg = Info.Target.getRegisterByName(LoweredTok))
+      AsmOperands[OperandNo].SingletonReg = Reg->TheDef;
     return;
   } 
 
@@ -828,7 +825,7 @@
 
   StringRef RegName = Tok.substr(RegisterPrefix.size());
   if (const CodeGenRegister *Reg = Info.Target.getRegisterByName(RegName))
-    AsmOperands[i].SingletonReg = Reg->TheDef;
+    AsmOperands[OperandNo].SingletonReg = Reg->TheDef;
 
   // If there is no register prefix (i.e. "%" in "%eax"), then this may
   // be some random non-register token, just ignore it.





More information about the llvm-commits mailing list