[llvm-commits] [patch] Remove MCLoggingStreamer
Chris Lattner
clattner at apple.com
Sun Jan 8 23:17:37 PST 2012
On Jan 6, 2012, at 7:50 PM, Rafael Ávila de Espíndola wrote:
> It looks to me that MCLoggingStreamer is costing more than it is worth.
>
> It is a interesting debugging idea, but it doesn't add a lot more
> information than the regular text asm printer. Specially in verbose asm
> mode.
>
> The value of the information being logged is also reduced when we split
> a method to provide a non-virtual interface. After the split, we are
> logging an implementation detail.
>
> While the situation can be improved with cleaner separation of the
> interface provided by MCStreamer and its implementation, it looks better
> to just remove the logging streamer.
Please do. Thanks Rafael,
-Chris
More information about the llvm-commits
mailing list