[llvm-commits] [llvm] r147727 - /llvm/trunk/utils/TableGen/FastISelEmitter.cpp

Cameron Zwarich zwarich at apple.com
Sat Jan 7 00:18:37 PST 2012


Author: zwarich
Date: Sat Jan  7 02:18:37 2012
New Revision: 147727

URL: http://llvm.org/viewvc/llvm-project?rev=147727&view=rev
Log:
Fix TableGen so that it will emit the correct signature for FastEmit_f:

  /// FastEmit_f - This method is called by target-independent code
  /// to request that an instruction with the given type, opcode, and
  /// floating-point immediate operand be emitted.
  virtual unsigned FastEmit_f(MVT VT,
                              MVT RetVT,
                              unsigned Opcode,
                              const ConstantFP *FPImm);

Currently, it emits an accidentally overloaded version without the const on the
ConstantFP*. This doesn't affect anything in the tree, since nothing causes that
method to be autogenerated, but I have been playing with some ARM TableGen
refactorings that hit this problem.

Modified:
    llvm/trunk/utils/TableGen/FastISelEmitter.cpp

Modified: llvm/trunk/utils/TableGen/FastISelEmitter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/FastISelEmitter.cpp?rev=147727&r1=147726&r2=147727&view=diff
==============================================================================
--- llvm/trunk/utils/TableGen/FastISelEmitter.cpp (original)
+++ llvm/trunk/utils/TableGen/FastISelEmitter.cpp Sat Jan  7 02:18:37 2012
@@ -280,7 +280,7 @@
       } else if (Operands[i].isImm()) {
         OS << "uint64_t imm" << i;
       } else if (Operands[i].isFP()) {
-        OS << "ConstantFP *f" << i;
+        OS << "const ConstantFP *f" << i;
       } else {
         llvm_unreachable("Unknown operand kind!");
       }





More information about the llvm-commits mailing list