[llvm-commits] [llvm] r147580 - in /llvm/trunk/test: CodeGen/X86/avx-shuffle-x86_32.ll CodeGen/X86/cmpxchg16b.ll CodeGen/XCore/2011-08-01-DynamicAllocBug.ll Transforms/InstCombine/icmp.ll Transforms/SimplifyCFG/preserve-branchweights.ll

[Benjamin Kramer]

On 05.01.2012, at 01:50, Chris Lattner wrote:

> 
> On Jan 4, 2012, at 4:43 PM, Benjamin Kramer wrote:
> 
>> Author: d0k
>> Date: Wed Jan  4 18:43:34 2012
>> New Revision: 147580
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=147580&view=rev
>> Log:
>> FileCheck hygiene.
> 
> Should FileCheck output a warning or error when the prefix is seen without a : or -NOT: ?

This sounds like a good idea, but it's not really feasible. We don't want to warn for a stray CHECK somewhere in the text (e.g. "-check-prefix=CHECK" in a RUN line). It would require teaching FileCheck about line beginnings, which would in turn require teaching FileCheck about comments in our various input formats.

Also this mistakes come in various flavors, for example:
- Missing : (the most common one)
- Wrong capitalization (ChECK, CHEck)
- Other typos (CHEKC, CHEK, CHECK;)

A better idea would be to add some kind of linter to lit which can also match other best practices but is allowed to produce false positives. I'm not annoyed enough to implement that at the moment though.

- Ben