[llvm-commits] Intel Atom optimization - use LEA to adjust stack pointer

[Zhang, Andy]

On Friday, December 23, 2011 11:06 PM, Jakob Stoklund Olesen wrote:
 
> On Dec 23, 2011, at 10:23 AM, Zhang, Andy wrote:
> 
> Hi Andy,
> 
> Please submit the TableGen changes as an independent patch.
> 
> From a quick glance, you also need to make sure you follow LLVM's style
> for braces etc.
> 
>      if (isSub)
> +    {
>        MI->setFlag(MachineInstr::FrameSetup);
> -    MI->getOperand(3).setIsDead(); // The EFLAGS implicit def is dead.
> +    }
> 
> Why add braces here?
> 
> /jakob

Hi Jakob,

I removed the braces from the single-statement if-statement blocks and updated the patch. Do you see any other issues?

Regards,
Andy

-------------- next part --------------
A non-text attachment was scrubbed...
Name: lea_sp.diff
Type: application/octet-stream
Size: 10689 bytes
Desc: lea_sp.diff
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120104/1c07bc14/attachment.obj>