[llvm-commits] [PATCH] Modify tablegen to use constants when there are more than 32 subtarget features

Jakob Stoklund Olesen stoklund at 2pi.dk
Tue Jan 3 15:08:28 PST 2012


On Jan 3, 2012, at 9:23 AM, Zhang, Andy wrote:

> Currently, TableGen uses an anonymous enum for subtarget features. When
> compiling with Visual C++, enums are always 'int's, so with more than 32 subtarget
> features, some values will overflow.
> 
> The attached patch modifies TableGen to emit 'const uint64_t' for subtarget
> features when there are more than 32 of them. It was split off from my
> earlier patch for Atom optimizations, as requested.
> 
> If this looks OK, could it be committed to trunk?

Committed r147491.

Thanks,
/jakob




More information about the llvm-commits mailing list