[llvm-commits] [zorg] r147461 - /zorg/trunk/lnt/lnt/server/reporting/analysis.py

[Daniel Dunbar]

Author: ddunbar
Date: Tue Jan  3 13:10:07 2012
New Revision: 147461

URL: http://llvm.org/viewvc/llvm-project?rev=147461&view=rev
Log:
[lnt/v0.4] lnt.server.ui/v4: Fix stddev estimation when all prev samples failed.

Modified:
    zorg/trunk/lnt/lnt/server/reporting/analysis.py

Modified: zorg/trunk/lnt/lnt/server/reporting/analysis.py
URL: http://llvm.org/viewvc/llvm-project/zorg/trunk/lnt/lnt/server/reporting/analysis.py?rev=147461&r1=147460&r2=147461&view=diff
==============================================================================
--- zorg/trunk/lnt/lnt/server/reporting/analysis.py (original)
+++ zorg/trunk/lnt/lnt/server/reporting/analysis.py Tue Jan  3 13:10:07 2012
@@ -98,13 +98,13 @@
             # runs.
             #
             # FIXME: This is using the wrong status kind. :/
-            prev_samples = [v for run in comparison_window
-                            for v in self.sample_map.get((run.id, test_id), ())]
+            prev_samples = [s for run in comparison_window
+                            for s in self.sample_map.get((run.id, test_id), ())]
+            # Filter out failing samples.
+            if status_field:
+                prev_samples = [s for s in prev_samples
+                                if s.get_field(status_field) == PASS]
             if prev_samples:
-                # Filter out failing samples.
-                if status_field:
-                    prev_samples = [s for s in prev_samples
-                                    if s.get_field(status_field) == PASS]
                 prev_values = [s.get_field(field)
                                for s in prev_samples]
                 stddev = stats.standard_deviation(prev_values)