[llvm-commits] XOP Intrinsics patch

[Jan Sjodin]

Yes, I saw your fixes after I sent out this patch. I will fix accordingly and also try and include the intrinsics patterns in the encoding.

Thanks,
Jan




>________________________________
> From: Craig Topper <craig.topper at gmail.com>
>To: Jan Sjodin <jan_sjodin at yahoo.com> 
>Cc: "llvm-commits at cs.uiuc.edu" <llvm-commits at cs.uiuc.edu> 
>Sent: Tuesday, January 3, 2012 1:17 PM
>Subject: Re: [llvm-commits] XOP Intrinsics patch
> 
>
>Adding some testcases that use the load patterns would probably be good too. I've been fixing a lot of these sort of patterns lately because they didn't understand the integer promotion.
>
>~Craig
>
>
>On Tue, Jan 3, 2012 at 10:14 AM, Craig Topper <craig.topper at gmail.com> wrote:
>
>All integer vector loads in patterns need to be memopv2i64(!28-bit) or memopv4i64(256-bit) and bitcasted to the correct type because all integer vector loads are promoted to v2i64 or v4i64. So for instance
>>
>>+def : Pat<(int_x86_xop_vphsubwd (alignedloadv8i16 addr:$src1)),
>>+          (VPHSUBWDrm addr:$src1)>;
>>
>>Needs to be 
>>
>>+def : Pat<(int_x86_xop_vphsubwd (bc_v8i16 (memopv2i64 addr:$src1))),
>>+          (VPHSUBWDrm addr:$src1)>;
>>
>>~Craig
>>
>>
>>On Tue, Jan 3, 2012 at 8:12 AM, Jan Sjodin <jan_sjodin at yahoo.com> wrote:
>>
>>This patch adds XOP intrinsics (including tests). Ok to commit?
>>>
>>>
>>>- Jan
>>>
>>>
>>>_______________________________________________
>>>llvm-commits mailing list
>>>llvm-commits at cs.uiuc.edu
>>>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>
>>>
>>
>>
>>-- 
>>~Craig
>>
>
>
>-- 
>~Craig
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120103/c05879a4/attachment.html>