[llvm-commits] [llvm] r147399 - in /llvm/trunk: lib/CodeGen/SelectionDAG/LegalizeDAG.cpp test/CodeGen/X86/avx-shuffle-x86_32.ll Please review

[Demikhovsky, Elena]

I fixed the patch and want to commit it. 
I re-checked all and CodeGen/ARM/vext.ll passes now.

Please review.


- Elena

-----Original Message-----
From: Rafael Ávila de Espíndola [mailto:rafael.espindola at gmail.com] 
Sent: Sunday, January 01, 2012 19:44
To: Demikhovsky, Elena
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [llvm-commits] [llvm] r147399 - in /llvm/trunk: lib/CodeGen/SelectionDAG/LegalizeDAG.cpp test/CodeGen/X86/avx-shuffle-x86_32.ll

On 01/01/12 11:22 AM, Elena Demikhovsky wrote:
> Author: delena
> Date: Sun Jan  1 10:22:47 2012
> New Revision: 147399
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=147399&view=rev
> Log:
> Fixed a bug in SelectionDAG.cpp.
> The failure seen on win32, when i64 type is illegal.
> It happens on stage of conversion VECTOR_SHUFFLE to BUILD_VECTOR.
> 
> The failure message is:
> llc: SelectionDAG.cpp:784: void VerifyNodeCommon(llvm::SDNode*): Assertion `(I->getValueType() == EltVT || (EltVT.isInteger() && I->getValueType().isInteger() && EltVT.bitsLE(I->getValueType()))) && "Wrong operand type!"' failed.
> 
> I added a special test that checks vector shuffle on win32.
> 

Hi Elena,

I reverted this because it broke CodeGen/ARM/vext.ll, which made the
bots red.

Cheers,
Rafael
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: legalize_dag.diff
Type: application/octet-stream
Size: 3789 bytes
Desc: legalize_dag.diff
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120102/250d5dd7/attachment.obj>