[llvm-commits] [pr11677][patch] Eagerly materialize functions whose BBs are used in global variables inits
Chandler Carruth
chandlerc at google.com
Sun Jan 1 22:14:40 PST 2012
This looks fine to me... A couple of minor points:
- Can you add some comments describing the iterator invalidation issues
that motivated this design?
- I think the unit test needs the boiler plate comment block at the top.
- I'd name the test itself after the PR number rather than putting it in a
comment (which is likely to not stay attached).
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120101/845de247/attachment.html>
More information about the llvm-commits
mailing list