[llvm-commits] [PATCH] Use an alternate symbol for function-size calc

Hal Finkel hfinkel at anl.gov
Thu Dec 29 19:52:55 PST 2011


On Thu, 2011-12-29 at 21:09 -0500, Rafael Ávila de Espíndola wrote:
> On 29/12/11 03:20 PM, Hal Finkel wrote:
> > This small patch fixes a compatibility problem between the ppc linux asm
> > printer and recent versions of binutils (as explained in the test case).
> > With this patch, llvm's behavior will again match that of gcc. It
> > touches CodeGen/AsmPrinter; please review.
> 
> Do you know when this was changed in binutils? Maybe we should always
> use the local symbol instead of making this a ppc only change.

I don't know exactly what version of binutils made the change, but I
believe it was sometime in 2011 (guessing from online bug reports);
binutils 2.21.1 displays the new behavior, 2.20.51.0.2 (which is from
2009) does not.

I think that always using the local symbol going to be a safe choice
(apparently safer than using the global symbol name). Do we have a
uniform way of getting that symbol?

Thanks again,
Hal

> 
> > Thanks again,
> > Hal
> 
> Cheers,
> Rafael
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-- 
Hal Finkel
Postdoctoral Appointee
Leadership Computing Facility
Argonne National Laboratory




More information about the llvm-commits mailing list