[llvm-commits] [PATCH] AddressSanitizer: avoid name conflicts between multiple mach_override instances.

[Alexander Potapenko]

I've sent some of them to the author, although we're a bit ahead of him again.
I'll try to ping him.

On Wed, Dec 28, 2011 at 5:12 AM, Kostya Serebryany <kcc at google.com> wrote:
> r147303 (I also added a README.txt entry).
> Please talk to the mach_override maintainers, they may want to accept some
> (or all) of our patches.
>
> --kcc
>
>
> On Tue, Dec 27, 2011 at 12:24 AM, Alexander Potapenko <glider at google.com>
> wrote:
>>
>> Hi,
>>
>> The code instrumented with ASan may have its own instance of the
>> mach_override library.
>> In this case chances are that functions from it will be called from
>> mach_override_ptr() during ASan initialization.
>> This may lead to crashes (if those functions are instrumented) or
>> incorrect behavior (if the implementations differ).
>>
>> The attached patch renames mach_override_ptr() into
>> __asan_mach_override_ptr() and makes the rest of the mach_override
>> internals hidden.
>> The corresponding AddressSanitizer bug is
>> http://code.google.com/p/address-sanitizer/issues/detail?id=22
>>
>> --
>> Alexander Potapenko
>> Software Engineer
>> Google Moscow
>
>



-- 
Alexander Potapenko
Software Engineer
Google Moscow