[llvm-commits] [PATCH][CMake] PR10050.

[arrowdodger]

On Sat, Dec 24, 2011 at 1:34 PM, Chandler Carruth <chandlerc at google.com>wrote:

> High level questions:
>
> Why generate tarballs as well as installing the actual docs?
>

Dunno, i've been following Makefile build.

Why set some of the binaries to 'true' and run those command
> unconditionally, but in other cases just omit steps when the tools
> necessary are unavailable? The latter sounds cleaner.
>

Yes, this seems OK. Will fix it.


> Does any of this happen for a normal build, or is it all only triggered by
> an explicit target or 'make install'?
>

All targets created by add_custom_target(tgt ALL ...) are run during normal
build, but also can be invoked explicitly with `make tgt`. Everything that
mentioned in install() is installed by `make install`.

Please go ahead and commit the cpack version number fix, it's independent
> of the rest.
>

I do not have commit rights.


> I'll try to look through these more carefully, but they're a bit
> confusing. Comments would likely help as the CMake languages doesn't make
> this kind of stuff obvious.
>

Thanks for quick review!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20111224/c2ea5739/attachment.html>