[llvm-commits] [PATCH] Removes most of the templating from the JSON parser

Chris Lattner clattner at apple.com
Thu Dec 22 10:25:12 PST 2011


On Dec 22, 2011, at 6:55 AM, Manuel Klimek wrote:

> I'm happy to apply this if people feel like this improves the
> situation. I'm not sure it does, though, which is why I'd like to get
> comments on it first. Better? Worse? The same? Ideas how to make it
> better?
> 
> Rietveld: http://codereview.appspot.com/5504072

I think that this is a lot better.  An improvement would be to keep some of the trivial methods (e.g. AtomIterator::AtomIterator) inline, which IMO makes things easier to read, and is probably better for performance.

-Chris



More information about the llvm-commits mailing list