[llvm-commits] PATCH: remove unused variable TheError

[Manuel Klimek]

On Wed, Dec 21, 2011 at 12:30 AM, James Molloy <James.Molloy at arm.com> wrote:
> Manuel,
>
> Do you have commit access? If not, I can commit for you.

Commited. Yes, I have access, I just wasn't sure where the line is for
"obvious" changes and was rather erring on the side of asking :)

Thanks,
/Manuel

>
> James
> ________________________________________
> From: llvm-commits-bounces at cs.uiuc.edu [llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Chandler Carruth [chandlerc at google.com]
> Sent: 20 December 2011 23:16
> To: Manuel Klimek
> Cc: llvm-commits at cs.uiuc.edu
> Subject: Re: [llvm-commits] PATCH: remove unused variable TheError
>
> On Tue, Dec 20, 2011 at 6:54 AM, Manuel Klimek <klimek at google.com<mailto:klimek at google.com>> wrote:
> While searching for an example to model my use of SourceMgr after, I
> stumbled over LLLexer.h and found what looks like an unused variable -
> this patch would remove it, if there's not some hidden use of TheError
> that I'm missing.
>
> Looks good. As long as this kind of change doesn't break the build in some way, always feel free to commit as "obvious".
>
>
> diff --git a/lib/AsmParser/LLLexer.h b/lib/AsmParser/LLLexer.h
> index 33b9135..09aea5b 100644
> --- a/lib/AsmParser/LLLexer.h
> +++ b/lib/AsmParser/LLLexer.h
> @@ -42,7 +42,6 @@ namespace llvm {
>    APFloat APFloatVal;
>    APSInt  APSIntVal;
>
> -    std::string TheError;
>  public:
>    explicit LLLexer(MemoryBuffer *StartBuf, SourceMgr &SM, SMDiagnostic &,
>                     LLVMContext &C);
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu<mailto:llvm-commits at cs.uiuc.edu>
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
> -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.
>