[llvm-commits] [llvm] r146977 - /llvm/trunk/lib/Target/ARM/AsmParser/ARMAsmParser.cpp

[Chandler Carruth]

Cool!

On Tue, Dec 20, 2011 at 9:38 AM, Jason W Kim <jason.w.kim.2009 at gmail.com>wrote:

> First steps in ARM AsmParser support for .eabi_attribute and .arch
> (Both used for Linux gnueabi)
> No behavioral change yet (no tests need so far)
>

Why no tests needed? We should have tests that just exercise the parsing,
no? If not, I think it would be good to wait on commit until enough
functionality is there to at least have a sanity test. Essentially, you
should have enough tests here to ensure you didn't commit an 'abort()' or a
divide by zero.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20111220/138d1670/attachment.html>