[llvm-commits] [PATCH] MC ARM Thumb: fix incorrect relocation generation (PR11214)

Jim Grosbach grosbach at apple.com
Tue Dec 20 11:32:32 PST 2011


Yeah, that's my guess. An assert(0 "unimplemented non-PLT call!") or something would have been better if that's the case exactly to prevent this sort of head-scratching. :)

-Jim

On Dec 20, 2011, at 11:21 AM, James Molloy wrote:

> Yeah, I was confused about that too.
> 
> I couldn't comprehend why that conditional was even there in the first place - an R_ARM_NONE relocation is *never* required for a call (it's a special no-op reloc).
> 
> The only thing I could think of is that someone wanted to fix the relocation given to PLT entries and decided to keep the a broken behaviour for the default case, perhaps they had no knowledge about it.
> ________________________________________
> From: llvm-commits-bounces at cs.uiuc.edu [llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Jim Grosbach [grosbach at apple.com]
> Sent: 20 December 2011 19:07
> To: Kristof Beyls
> Cc: llvm-commits at cs.uiuc.edu
> Subject: Re: [llvm-commits] [PATCH] MC ARM Thumb: fix incorrect relocation generation (PR11214)
> 
> Someone with ELF knowledge should look at this. I'm a bit nervous about removing the conditional as it seems to imply that there's an different relocation that should be generated depending on the variant kind.
> 
> -Jim
> 
> On Dec 20, 2011, at 5:43 AM, Kristof Beyls wrote:
> 
>> Hi,
>> 
>> Please find a patch for fixing incorrect generation of relocation
>> information on Thumb function calls.
>> This should fix quite a few incorrect code generation problems in Thumb mode
>> when using the integrated assembler.
>> I believe this fixes PR11214
>> (http://www.llvm.org/bugs/show_bug.cgi?id=11214).
>> 
>> Is this OK?
>> 
>> Thanks,
>> 
>> Kristof
>> <fix_thumbcall_reloc.patch>_______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 
> 
> -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.
> 




More information about the llvm-commits mailing list