[llvm-commits] [PATCH] Add basic ELF Dyld loader (on behalf of Andy Kaylor)

Eric Christopher echristo at apple.com
Wed Dec 14 11:45:09 PST 2011


On Dec 14, 2011, at 10:53 AM, Rafael Ávila de Espíndola wrote:

> +      case sys::COFF_FileType:
> +      default:
> 

As a preference...
> If you are going to use a default you don't need to list
> sys::COFF_FileType.

Not this,

> Alternatively, drop the default so that we get an
> warning when someone adds something to the enum.



 but this one.

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20111214/b3f0e7bd/attachment.html>


More information about the llvm-commits mailing list