[llvm-commits] [PATCH] Allow inline when calling returns_twice
joerg at britannica.bec.de
Wed Dec 14 05:54:07 PST 2011
On Wed, Dec 14, 2011 at 02:09:21PM +0100, Duncan Sands wrote:
> your scheme seemed to be making a bunch of assumptions about how people use
> "returns_twice" functions. If you are confident that those assumptions are
> valid then, sure, go ahead with your scheme.
My assumption is that the problematic cases (live ranges of local
variables) are already handled in both the caller and the callee by
appropiate use of volatile. This should be ensured by the pre-existing
returns_twice attribute. I don't want to auto-attribute functions with
it (which would allow more aggressive inlining), since that would
require such changes when the user doesn't expect it. Am I wrong?
More information about the llvm-commits