[llvm-commits] [llvm] r146527 - /llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp

[Kostya Serebryany]

Author: kcc
Date: Tue Dec 13 18:01:51 2011
New Revision: 146527

URL: http://llvm.org/viewvc/llvm-project?rev=146527&view=rev
Log:
[asan] remove .preinit_array from the compiler module (it breaks .so builds). This should be done in the run-time. 

Modified:
    llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp

Modified: llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp?rev=146527&r1=146526&r2=146527&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp (original)
+++ llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp Tue Dec 13 18:01:51 2011
@@ -163,8 +163,6 @@
 
  private:
 
-  void appendToPreinitArray(Module &M, Function *F);
-
   uint64_t getAllocaSizeInBytes(AllocaInst *AI) {
     Type *Ty = AI->getAllocatedType();
     uint64_t SizeInBytes = TD->getTypeStoreSizeInBits(Ty) / 8;
@@ -565,17 +563,6 @@
   return true;
 }
 
-// .preinit_array is something that hapens before all other inits.
-// On systems where .preinit_array is honored, we will call __asan_init early.
-void AddressSanitizer::appendToPreinitArray(Module &M, Function *F) {
-  IRBuilder<> IRB(M.getContext());
-  GlobalVariable *Var =
-      new GlobalVariable(M, PointerType::getUnqual(F->getFunctionType()),
-                         false, GlobalValue::PrivateLinkage,
-                         F, "__asan_preinit_private");
-  Var->setSection(".preinit_array");
-}
-
 // virtual
 bool AddressSanitizer::runOnModule(Module &M) {
   // Initialize the private fields. No one has accessed them before.
@@ -647,9 +634,6 @@
 
   appendToGlobalCtors(M, AsanCtorFunction, 1 /*high priority*/);
 
-  if (M.getTargetTriple().find("linux") != std::string::npos)
-    appendToPreinitArray(M, AsanInitFunction);
-
   return Res;
 }