[llvm-commits] [llvm] r146492 - /llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp

[Chad Rosier]

On Dec 13, 2011, at 10:58 AM, Chris Lattner wrote:

> 
> On Dec 13, 2011, at 10:18 AM, Chad Rosier wrote:
>>> Are you sure that this isn't used?  On X86-64, we do need to return aggregates to match the ABI.  This is typically seen as a series of insertvalues right before the return.  Is this simple case being handled still?
>> 
>> I implemented this last week, but Dan explained to me that fast-isel was never designed to support instructions that return an aggregate type (or rather define a series of registers).  I believe UpdateValueMap wasn't designed to handle this case.
> 
> Aha, ok.  I was just concerned about a regression on x86-64 not about enabling a new class of stuff.  Thanks for checking.
> 

No problem.

 Chad


> -Chris