[llvm-commits] [llvm] r146439 - in /llvm/trunk: include/llvm/Bitcode/ReaderWriter.h lib/Bitcode/Writer/BitcodeVerifier.cpp

[Chris Lattner]

On Dec 12, 2011, at 3:33 PM, Chris Lattner wrote:

> 
> On Dec 12, 2011, at 2:57 PM, Chad Rosier wrote:
> 
>> Author: mcrosier
>> Date: Mon Dec 12 16:57:31 2011
>> New Revision: 146439
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=146439&view=rev
>> Log:
>> Begin sketching out a bitcode verifier pass.  Idea is to emit a .bc file and
>> then read the file back in to verify use-list serialization/deserialization.
> 
> Hi Chad,
> 
> Can you pick a different name than 'verifier' for this?  I think it will be very confusing to people.  How about "Validator" or something else?

Actually, a more basic question: why is this a pass at all?  This doesn't follow the structure of other passes.  It seems that it should just be a free function or some utility somewhere.

-Chris