[llvm-commits] x86 branch sequence optimization in LLVM code gen: please review

[Bruno Cardoso Lopes]

On Wed, Dec 7, 2011 at 1:03 PM, Umansky, Victor
<victor.umansky at intel.com> wrote:
>
> Hi Chad, Anton, Bruno,
>
>
>
> Thank you for the suggestion.
>
>
>
> Unfortunately, it won’t work in the case of brcond.ll file.
>
>
>
> Indeed I can introduce different “check-prefix” values in order to separate checks for “core2” case from those for “penryn” case.
>
> However, the compilation of all functions in a file will be done unconditionally for both “RUN” cases. And this will inevitably lead to the test failure (in instruction selection) when a function using “ptest” LLVM intrinsic will be processed with “-mcpu=core2” option.
>
> That’s why I was not able to include the test cases for “ptest” intrinsic sequence to a file which will be compiled for a pre-Penryn target.
>
>
>
> A solution which does work is to have legacy brcond.ll LIT tests running under “-mcpu=penryn”.
>
> I’m attaching the file.
>
> Are you OK with such solution?

LGTM, please resend the orignal patch with the testcase (both in the
same patch file)! Also remove the trailing CRs and generate the diff
with "svn diff" under the project root. If you have any question, the
docs may help: http://llvm.org/docs/DeveloperPolicy.html#patches

--
Bruno Cardoso Lopes
http://www.brunocardoso.cc