[llvm-commits] [llvm] r145916 - in /llvm/trunk/test/MC: ARM/relax-thumb2-branches.s MachO/relax-thumb2-branches.s

[Jim Grosbach]

On Dec 5, 2011, at 10:05 PM, NAKAMURA Takumi wrote:

> Jim,
> 
> 2011/12/6 Jim Grosbach <grosbach at apple.com>:
>> MC/MachO does not assume X86. There are other tests for ARM there as well.
> 
> I didn't find {arm|thumb} in MC/MachO. Did I miss anything?

Hmmm. They must have been moved. There used to be, I'm almost certain of it. In any case, see below.

> Please see also test/MC/MachO/dg.exp

That is wrong. There is nothing target specific about that directory.

>> For the time being, please revert this change. The test was in the correct place.
> 
> I won't agree to revert. It would fail if enable_targets did not contain ARM.

Then the predicate on the directory is wrong. Moving the test to MC/ARM is not the correct solution.

> Would it be better if MC/MachO/ARM were there?

That's what I was suggesting, yes. Please do this.

Tests which generate MachO object files belong in the MachO directory, not the ARM directory. The MC/ARM tests aren't supposed to be testing object file format specific features, but rather target-independent parsing and encoding bits.

-Jim