[llvm-commits] [llvm] r145916 - in /llvm/trunk/test/MC: ARM/relax-thumb2-branches.s MachO/relax-thumb2-branches.s

[Jim Grosbach]

MC/MachO does not assume X86. There are other tests for ARM there as well.

Tests which produce an object file, which this one does, belong in the MachO directory, not the MC/ARM directory.

That said, I agree there's some oddness in the directory structure. Having target sub-dirs in the MachO directory isn't a bad idea, for example.

For the time being, please revert this change. The test was in the correct place.

-Jim


On Dec 5, 2011, at 7:56 PM, NAKAMURA Takumi wrote:

> Author: chapuni
> Date: Mon Dec  5 21:56:05 2011
> New Revision: 145916
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=145916&view=rev
> Log:
> test/MC: Move relax-thumb2-branches.s from MC/MachO/ to MC/ARM.
> 
> MC/MachO assumes x86.
> 
> Added:
>    llvm/trunk/test/MC/ARM/relax-thumb2-branches.s
>      - copied, changed from r145913, llvm/trunk/test/MC/MachO/relax-thumb2-branches.s
> Removed:
>    llvm/trunk/test/MC/MachO/relax-thumb2-branches.s
> 
> Copied: llvm/trunk/test/MC/ARM/relax-thumb2-branches.s (from r145913, llvm/trunk/test/MC/MachO/relax-thumb2-branches.s)
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/ARM/relax-thumb2-branches.s?p2=llvm/trunk/test/MC/ARM/relax-thumb2-branches.s&p1=llvm/trunk/test/MC/MachO/relax-thumb2-branches.s&r1=145913&r2=145916&rev=145916&view=diff
> ==============================================================================
>    (empty)
> 
> Removed: llvm/trunk/test/MC/MachO/relax-thumb2-branches.s
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/MachO/relax-thumb2-branches.s?rev=145915&view=auto
> ==============================================================================
> --- llvm/trunk/test/MC/MachO/relax-thumb2-branches.s (original)
> +++ llvm/trunk/test/MC/MachO/relax-thumb2-branches.s (removed)
> @@ -1,14 +0,0 @@
> -@ RUN: llvm-mc -triple=thumbv7-apple-darwin -show-encoding %s -filetype=obj -o - | macho-dump --dump-section-data | FileCheck %s
> -
> -        ble Lfoo        @ wide encoding
> -
> -        .space 258
> -Lfoo:
> -        nop
> -
> -        ble Lbaz        @ narrow encoding
> -        .space 256
> -Lbaz:
> -
> -@ CHECK: '_section_data', '40f38180
> -@ CHECK: 000000bf 7fdd
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits