[llvm-commits] [llvm] r145894 - in /llvm/trunk/lib/Target: Mips/MCTargetDesc/MipsAsmBackend.cpp PowerPC/MCTargetDesc/PPCAsmBackend.cpp

[David Blaikie]

On Tue, Dec 6, 2011 at 1:48 AM, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
> Author: chapuni
> Date: Mon Dec  5 19:48:32 2011
> New Revision: 145894
>
> URL: http://llvm.org/viewvc/llvm-project?rev=145894&view=rev
> Log:
> MipsAsmBackend.cpp, PPCAsmBackend.cpp: Fix -Asserts build to appease msvc.
>
> Modified:
>    llvm/trunk/lib/Target/Mips/MCTargetDesc/MipsAsmBackend.cpp
>    llvm/trunk/lib/Target/PowerPC/MCTargetDesc/PPCAsmBackend.cpp
>
> Modified: llvm/trunk/lib/Target/Mips/MCTargetDesc/MipsAsmBackend.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MCTargetDesc/MipsAsmBackend.cpp?rev=145894&r1=145893&r2=145894&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Target/Mips/MCTargetDesc/MipsAsmBackend.cpp (original)
> +++ llvm/trunk/lib/Target/Mips/MCTargetDesc/MipsAsmBackend.cpp Mon Dec  5 19:48:32 2011
> @@ -181,6 +181,7 @@
>                             const MCAsmLayout &Layout) const {
>     // FIXME.
>     assert(0 && "RelaxInstruction() unimplemented");
> +    return false;

Does llvm_unreachable also (as an alternative, not in addition to) silence MSVC?

>   }
>
>   /// RelaxInstruction - Relax the instruction in the given fragment
>
> Modified: llvm/trunk/lib/Target/PowerPC/MCTargetDesc/PPCAsmBackend.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/MCTargetDesc/PPCAsmBackend.cpp?rev=145894&r1=145893&r2=145894&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Target/PowerPC/MCTargetDesc/PPCAsmBackend.cpp (original)
> +++ llvm/trunk/lib/Target/PowerPC/MCTargetDesc/PPCAsmBackend.cpp Mon Dec  5 19:48:32 2011
> @@ -100,6 +100,7 @@
>                             const MCAsmLayout &Layout) const {
>     // FIXME.
>     assert(0 && "RelaxInstruction() unimplemented");
> +    return false;
>   }
>
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits