[llvm-commits] [llvm] r145888 - /llvm/trunk/lib/Target/X86/X86FrameLowering.cpp

[Eric Christopher]

On Dec 5, 2011, at 5:26 PM, Bill Wendling wrote:

> -    RegEnc |= (CURegNum & 0x7) << (5 - I);
> +    RegEnc |= (CURegNum & 0x7) << ((5 - I) * 3);

Boo! Confusing numbers! Boo!

How about at least a comment saying where the numbers come from? :)

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20111205/8eee0997/attachment.html>