[llvm-commits] [llvm] r145865 - in /llvm/trunk: lib/Transforms/Scalar/MemCpyOptimizer.cpp test/Transforms/MemCpyOpt/form-memset.ll

Chad Rosier mcrosier at apple.com
Mon Dec 5 14:50:01 PST 2011


Yes, juggling too many things at once.  Will do.

 Chad

On Dec 5, 2011, at 2:44 PM, Bob Wilson wrote:

> 
> On Dec 5, 2011, at 2:42 PM, Bob Wilson wrote:
> 
>> I think you meant <rdar://problem/9892684>
>> 
>> On Dec 5, 2011, at 2:37 PM, Chad Rosier wrote:
>> 
>>> Author: mcrosier
>>> Date: Mon Dec  5 16:37:00 2011
>>> New Revision: 145865
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=145865&view=rev
>>> Log:
>>> Make the MemCpyOptimizer a bit more aggressive.  I can't think of a scenerio
>>> where this would be bad as the backend shouldn't have a problem inlining small
>>> memcpys.
>>> rdar://10510150
>>> 
>>> Modified:
>>>  llvm/trunk/lib/Transforms/Scalar/MemCpyOptimizer.cpp
>>>  llvm/trunk/test/Transforms/MemCpyOpt/form-memset.ll
>>> 
>>> Modified: llvm/trunk/lib/Transforms/Scalar/MemCpyOptimizer.cpp
>>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/MemCpyOptimizer.cpp?rev=145865&r1=145864&r2=145865&view=diff
>>> ==============================================================================
>>> --- llvm/trunk/lib/Transforms/Scalar/MemCpyOptimizer.cpp (original)
>>> +++ llvm/trunk/lib/Transforms/Scalar/MemCpyOptimizer.cpp Mon Dec  5 16:37:00 2011
>>> @@ -148,7 +148,7 @@
>>> 
>>> bool MemsetRange::isProfitableToUseMemset(const TargetData &TD) const {
>>> // If we found more than 8 stores to merge or 64 bytes, use memset.
>>> -  if (TheStores.size() >= 8 || End-Start >= 64) return true;
>>> +  if (TheStores.size() >= 4 || End-Start >= 16) return true;
> 
> …and please update the comment to match.





More information about the llvm-commits mailing list