[llvm-commits] [llvm] r145819 - in /llvm/trunk: lib/Target/PowerPC/PPCFrameLowering.cpp lib/Target/PowerPC/PPCInstrInfo.cpp lib/Target/PowerPC/PPCRegisterInfo.cpp test/CodeGen/PowerPC/2008-03-05-RegScavengerAssert.ll test/CodeGen/PowerPC/2008-03-17-RegScavengerCrash.ll test/CodeGen/PowerPC/2008-03-18-RegScavengerAssert.ll test/CodeGen/PowerPC/2010-02-12-saveCR.ll test/CodeGen/PowerPC/Frames-alloca.ll test/CodeGen/PowerPC/ppc32-vaarg.ll

[Hal Finkel]

On Mon, 2011-12-05 at 10:12 -0800, Jakob Stoklund Olesen wrote:
> On Dec 5, 2011, at 9:55 AM, Hal Finkel wrote:
> 
> > Author: hfinkel
> > Date: Mon Dec  5 11:55:17 2011
> > New Revision: 145819
> > 
> > URL: http://llvm.org/viewvc/llvm-project?rev=145819&view=rev
> > Log:
> > enable PPC register scavenging by default (update tests and remove some FIXMEs)
> 
> Nice!
> 
> Did you run extensive tests with this change?

Not extensive; I ran the regression tests and a few other files I've
been using recently. I'll be setup soon to run the test suite on ppc64,
and so I'll test more-extensively using the test suite. Unfortunately,
there are still other problems that I have to fix first (like PR11476,
which may be related to register scavenging, but was not fixed by these
changes).

>  Does it work with -O0?

Good point, I'll run some more tests (and the test suite) with -O0. Some
of the regression tests specify -O0 (like the varargs test, which seemed
to be fine).

Thanks again,
Hal

> 
> The register scavenger is notorious for exposing sloppy liveness info in older targets like PPC. I would expect a number of scavenger assertions.
> 
> /jakob
> 

-- 
Hal Finkel
Postdoctoral Appointee
Leadership Computing Facility
Argonne National Laboratory