[llvm-commits] Cleanup in ASan interceptors (issue 5437128)

konstantin.s.serebryany at gmail.com konstantin.s.serebryany at gmail.com
Sat Dec 3 17:20:31 PST 2011


[off-topic: is llvm-commits interested in asan-rt-specific code
reviews?]


http://codereview.appspot.com/5437128/diff/1/Makefile.old
File Makefile.old (right):

http://codereview.appspot.com/5437128/diff/1/Makefile.old#newcode162
Makefile.old:162: ASAN_LD_TAIL=$(LIBASAN_A)
We should not need it.
If we still need it (what's the case?), the fix should go to clang
driver. (This might work as a temporary fix though since the makefile
should die anyway)

http://codereview.appspot.com/5437128/diff/1/asan_interceptors.cc
File asan_interceptors.cc (right):

http://codereview.appspot.com/5437128/diff/1/asan_interceptors.cc#newcode96
asan_interceptors.cc:96: #define ENSURE_ASAN_INITED do { \
make it ENSURE_ASAN_INITED() (here and below)

http://codereview.appspot.com/5437128/diff/1/asan_interceptors.cc#newcode101
asan_interceptors.cc:101: } while (0);
remove ';'

http://codereview.appspot.com/5437128/



More information about the llvm-commits mailing list