[llvm-commits] [llvm] r145559 - in /llvm/trunk: include/llvm/Analysis/ lib/Analysis/ lib/Transforms/Scalar/ lib/Transforms/Utils/

[Chad Rosier]

Hi Duncan,
The issue I'm trying to resolve is in ConstantFoldCall.  Specifically, we shouldn't be folding library calls when -fno-builtin is specified; this requires TargetLibraryInfo.  Unfortunately, the folding routines are designed to be independent of a Pass, but getAnalysis and getAnalysisIfAvailable are not.  Therefore, I used the same convention as TargetData (i.e., pass it all over creation).  If I'm missing something here someone please chime in as I'm not particularly fond of the solution either.

Also, please reply all in the future as I may miss something only addressed to the list. :)

 Chad

On Dec 1, 2011, at 12:34 AM, Duncan Sands wrote:

> Hi Chad,
> 
>> Propagate TargetLibraryInfo throughout ConstantFolding.cpp and
>> InstructionSimplify.cpp.  Other fixups as needed.
>> Part of rdar://10500969
> 
> rather than doing it this way (i.e. passing it all over the compiler), how about
> instead having the places that need it use getAnalysisIfAvailable to obtain it.
> 
> Ciao, Duncan.
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits