[llvm-commits] Fix in VSQRTSSm_Int pattern in X86 AVX CodeGen - Please review

Bruno Cardoso Lopes bruno.cardoso at gmail.com
Mon Nov 28 07:35:18 PST 2011


Hi Elena,

On Mon, Nov 28, 2011 at 8:31 AM, Demikhovsky, Elena
<elena.demikhovsky at intel.com> wrote:
> Fixed an order of operands in VSQRTSSm_Int form:
>
>   def SSm_Int : SSI<opc, MRMSrcMem, (outs VR128:$dst),
> -                (ins ssmem:$src1, VR128:$src2),
> +                (ins VR128:$src1, ssmem:$src2),
>                 !strconcat(OpcodeStr,
>                            "ss\t{$src2, $src1, $dst|$dst, $src1, $src2}"), []>;
>
> Provided a test case.

Looks great! But please provide a more reduced testcase, and place it
inside avx-arith.ll

-- 
Bruno Cardoso Lopes
http://www.brunocardoso.cc




More information about the llvm-commits mailing list