[llvm-commits] MachOObjectFile fix functions

[Owen Anderson]

Danil,

I'm good with this version.  Go ahead and apply.

--Owen

On Nov 24, 2011, at 12:05 PM, Danil Malyshev wrote:

> ping
>  
> From: Danil Malyshev 
> Sent: Saturday, November 12, 2011 3:00 AM
> To: 'Owen Anderson'
> Cc: 'llvm-commits at cs.uiuc.edu'
> Subject: RE: [llvm-commits] MachOObjectFile fix functions
>  
> Hello Owen
>  
> > I see your reasoning here, but it scares me a little bit to have methods with the same name that do different things.
> > I think we should either rename them to be obviously different, or pick a consistent meaning for all of them.
>  
> I have renamed symbol.getOffset() as getFileOffset().
> Please find attached the changed patch.
>  
> Regards,
> Danil
>  

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20111125/52b4d174/attachment.html>