[llvm-commits] [polly] r143960 - in /polly/trunk: include/polly/Support/SCEVValidator.h lib/Analysis/ScopDetection.cpp lib/Support/CMakeLists.txt lib/Support/SCEVValidator.cpp

[Tobias Grosser]

On 11/16/2011 06:14 AM, Sebastian Pop wrote:
> On Mon, Nov 7, 2011 at 6:58 AM, Tobias Grosser
> <grosser at fim.uni-passau.de>  wrote:
>> Author: grosser
>> Date: Mon Nov  7 06:58:54 2011
>> New Revision: 143960
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=143960&view=rev
>> Log:
>> SCEVValidator: Move into own file
>> Added: polly/trunk/lib/Support/SCEVValidator.cpp
>> URL: http://llvm.org/viewvc/llvm-project/polly/trunk/lib/Support/SCEVValidator.cpp?rev=143960&view=auto
>> ==============================================================================
>> --- polly/trunk/lib/Support/SCEVValidator.cpp (added)
>> +++ polly/trunk/lib/Support/SCEVValidator.cpp Mon Nov  7 06:58:54 2011
>> @@ -0,0 +1,231 @@

[...]

>> +using namespace llvm;
>> +
>> +namespace SCEVType {
>> +  enum TYPE {INT, PARAM, IV, INVALID};
>
> You should probably document what each stands for, and also document
> the fact that the order in which the elements of the enum are arranged is
> important as we call max on their value.

You are right.

Documentation added in

"SCEVValidator: Document SCEVType and ValidatorResult"

Tobi