[llvm-commits] [patch][pr11202] Handle BB with address taken being deleted from codegen

Eli Friedman eli.friedman at gmail.com
Mon Nov 14 13:03:37 PST 2011


2011/11/14 Rafael EspĂ­ndola <rafael.espindola at gmail.com>:
> Both Eli and Joshua pointed out that having to manually call
> UpdateForDeletedMachineBlock was error prone.
>
> Eli suggested keeping track of which symbols are used and print the
> missing ones at the end. This patch implements this. One nice property
> is that it works both for IL and machine code. One problem is that the
> labels are printed at the end of the file, not at the start of the
> function they would be in. Not sure if that is real problem.

Might be an issue: we could end up with bad relocations if the labels
end up in the wrong section.

> The handling of RAUW still depends on the callback, but fortunately I
> don't think we RAUW machine basic blocks.

MBB's don't have use lists; not sure what RAUW'ing one would mean.

-Eli




More information about the llvm-commits mailing list