[llvm-commits] FW: AVX1 Code Generation - VSHUFP extension

[Demikhovsky, Elena]

Please commit this patch. I don't have write permissions yet.

- Elena

-----Original Message-----
From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Demikhovsky, Elena
Sent: Thursday, November 10, 2011 09:50
To: Bruno Cardoso Lopes
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [llvm-commits] AVX1 Code Generation - VSHUFP extension

No problem. I attached the new patch.

- Elena

-----Original Message-----
From: Bruno Cardoso Lopes [mailto:bruno.cardoso at gmail.com]
Sent: Wednesday, November 09, 2011 18:43
To: Demikhovsky, Elena
Cc: Eli Friedman; llvm-commits at cs.uiuc.edu
Subject: Re: [llvm-commits] AVX1 Code Generation - VSHUFP extension

Hi,

> I fixed the comments, I put 2 functions isCommutedVSHUFP() together.
>
> If this patch is good, please commit it.

Looks great! Just one more fix:

+static void CommuteVectorShuffleMask(SmallVectorImpl<int> &Mask, EVT 
+VT);
+
+
+
+/// isCommutedVSHUFP() - Return true if swapping operands will ///  
+allow to use the "vshufpd" or "vshufps" instruction ///  for 256-bit 
+vectors
+
+static bool isCommutedVSHUFPMask(const SmallVectorImpl<int> &Mask, EVT VT,
+                               const X86Subtarget *Subtarget) {

Please move the function definition up so you don't need to use a declaration, and make the comment above tied to the function (no newline between them).

--
Bruno Cardoso Lopes
http://www.brunocardoso.cc
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vshufp3.diff
Type: application/octet-stream
Size: 4284 bytes
Desc: vshufp3.diff
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20111113/a830f90c/attachment.obj>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ATT00001..txt
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20111113/a830f90c/attachment.txt>