[llvm-commits] ExecutionEngine move Intercept.cpp

[Jim Grosbach]

I don't think we want to do this yet. For now, the code is similar, but this will not be the case soon. The MCJIT will almost certainly do things differently. Consider the current code on that side as a placeholder. If, once we have a real solution in place for this part of the MCJIT, there's still lots of commonality, then we can look at combining them.

-Jim

On Nov 11, 2011, at 11:55 AM, Danil Malyshev wrote:

> ping
>  
> From: Danil Malyshev 
> Sent: Friday, November 04, 2011 1:51 AM
> To: 'llvm-commits at cs.uiuc.edu'
> Subject: ExecutionEngine move Intercept.cpp
>  
> Hello everyone,
>  
>  
> Please find attached the patch for review.
> We have 2 similar implementations of getPointerToNamedFunction in MCJIT/Intercept.cpp and in JIT/Intercept.cpp.
> I have re-factored this to move it to the ExecutionEngine so both MCJIT and JIT could use a single implementation.
> Besides, ExecutionEngine looks like a right place for this method.
>  
>  
> Regards,
> Danil
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits