[llvm-commits] [llvm] r144319 - in /llvm/trunk/lib/CodeGen/AsmPrinter: DwarfCompileUnit.h DwarfDebug.cpp

[Devang Patel]

On Nov 10, 2011, at 2:06 PM, Eric Christopher wrote:

> 
> On Nov 10, 2011, at 1:58 PM, Devang Patel wrote:
> 
>> 
>> On Nov 10, 2011, at 1:47 PM, Eric Christopher wrote:
>> 
>>> Author: echristo
>>> Date: Thu Nov 10 15:47:55 2011
>>> New Revision: 144319
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=144319&view=rev
>>> Log:
>>> Make types and namespaces take multiple DIEs for the accelerator tables
>>> as well.
>>> 
>>> Modified:
>>>    llvm/trunk/lib/CodeGen/AsmPrinter/DwarfCompileUnit.h
>>>    llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
>>> 
>>> Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfCompileUnit.h
>>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfCompileUnit.h?rev=144319&r1=144318&r2=144319&view=diff
>>> ==============================================================================
>>> --- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfCompileUnit.h (original)
>>> +++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfCompileUnit.h Thu Nov 10 15:47:55 2011
>>> @@ -64,8 +64,8 @@
>>>   ///
>>>   StringMap<std::vector<DIE*> > AccelNames;
>>>   StringMap<std::vector<DIE*> > AccelObjC;
>>> -  StringMap<DIE*> AccelNamespace;
>>> -  StringMap<DIE*> AccelTypes;
>>> +  StringMap<std::vector<DIE*> > AccelNamespace;
>>> +  StringMap<std::vector<DIE*> > AccelTypes;
>> 
>> SmallVector ?
> 
> Wasn't sure how many of them I thought I'd have, but yeah, looks reasonable for that.

SmallVector is efficient if the element count is not too high and and you can reasonably estimate a good starting size. 
-
Devang

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20111110/6808651c/attachment.html>