[llvm-commits] [llvm] r144321 - /llvm/trunk/lib/Target/MBlaze/Disassembler/LLVMBuild.txt

[Wesley Peck]

I am currently in the process of writing my dissertation so I am pretty busy. I'll try to take a look at how to fix this as soon as I have some free time. If this is causing other people problems then just let me know and I'll allocate some cycles to fixing it.
--
Wesley Peck
University of Kansas
SLDG Laboratory

On Nov 10, 2011, at 4:05 PM, Daniel Dunbar wrote:

> Hey Wesley,
> 
> If you are bored, it might be nice to fix this layering violation at
> some point. I didn't look deeply, but those static variables perhaps
> can be moved out of the generated header?
> 
> - Daniel
> 
> On Thu, Nov 10, 2011 at 2:00 PM, Daniel Dunbar <daniel at zuster.org> wrote:
>> Author: ddunbar
>> Date: Thu Nov 10 16:00:37 2011
>> New Revision: 144321
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=144321&view=rev
>> Log:
>> build/MBlazeDisassembler: Some compilers may generate an MBlaze disassembler
>> that depends on MBlazeCodeGen. This is a layering violation that should really
>> be fixed.
>> 
>> Modified:
>>    llvm/trunk/lib/Target/MBlaze/Disassembler/LLVMBuild.txt
>> 
>> Modified: llvm/trunk/lib/Target/MBlaze/Disassembler/LLVMBuild.txt
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/MBlaze/Disassembler/LLVMBuild.txt?rev=144321&r1=144320&r2=144321&view=diff
>> ==============================================================================
>> --- llvm/trunk/lib/Target/MBlaze/Disassembler/LLVMBuild.txt (original)
>> +++ llvm/trunk/lib/Target/MBlaze/Disassembler/LLVMBuild.txt Thu Nov 10 16:00:37 2011
>> @@ -19,6 +19,12 @@
>>  type = Library
>>  name = MBlazeDisassembler
>>  parent = MBlaze
>> -required_libraries = MBlazeDesc MBlazeInfo MC Support
>> +; Strictly speaking, we probably shouldn't have a dependency on
>> +; MBlazeCodeGen. However, given the current factoring we end up including
>> +; MBlazeGenRegisterInfo.inc in the disassembler. Those generated headers end up
>> +; referencing external variables through GPRRegClass, SPRRegClass, and
>> +; CRCRegClass. These aren't actually used, but some compilers may generate
>> +; references to them.
>> +required_libraries = MBlazeCodeGen MBlazeDesc MBlazeInfo MC Support
>>  add_to_library_groups = MBlaze
>> 
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>