[llvm-commits] [llvm] r144290 - /llvm/trunk/test/CodeGen/X86/lsr-loop-exit-cond.ll

Duncan Sands baldrick at free.fr
Thu Nov 10 06:57:56 PST 2011


Hi Takumi,

On 10/11/11 15:48, NAKAMURA Takumi wrote:
> 2011/11/10 Duncan Sands<baldrick at free.fr>:
>> Hi Takumi, is this correct?  I think this test is checking that the compare
>> occurs next to the branch.  If that's not working on some platforms shouldn't
>> that be fixed rather than hidden?
>
> As far as I checked freebsd bots, They say;
> "movl (" expected, but "movl XXX(" seen after "decq".
> It is just as same as on linux.

exactly!  This test tests that that doesn't happen - but it's failing.
Changing the triple until the issue goes away is just hiding the fact
that something is not working as expected.

Ciao, Duncan.

PS: I got this idea of what the test is checking by reading the svn log.
I could be wrong.

>
> FYI, it could be reproduced with -mtriple=x86_64-{linux|freebsd}.
>
> ...Ah, it might be possible simply to relax 2nd CHECK.
> Feel free to rewrite. gotta sleep.
>
> ...Takumi




More information about the llvm-commits mailing list