[llvm-commits] [polly] r144284 - /polly/trunk/lib/Analysis/ScopDetection.cpp

[Tobias Grosser]

Author: grosser
Date: Thu Nov 10 06:47:21 2011
New Revision: 144284

URL: http://llvm.org/viewvc/llvm-project?rev=144284&view=rev
Log:
ScopDetect: Use INVALID macro to fail in case of aliasing

This simplifies the code and also makes the error message available to
the graphviz scop viewer.

Modified:
    polly/trunk/lib/Analysis/ScopDetection.cpp

Modified: polly/trunk/lib/Analysis/ScopDetection.cpp
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/lib/Analysis/ScopDetection.cpp?rev=144284&r1=144283&r2=144284&view=diff
==============================================================================
--- polly/trunk/lib/Analysis/ScopDetection.cpp (original)
+++ polly/trunk/lib/Analysis/ScopDetection.cpp Thu Nov 10 06:47:21 2011
@@ -241,22 +241,8 @@
   AliasSet &AS =
     Context.AST.getAliasSetForPointer(BaseValue, AliasAnalysis::UnknownSize,
                                       Inst.getMetadata(LLVMContext::MD_tbaa));
-  if (!AS.isMustAlias()) {
-    DEBUG(dbgs() << "Bad pointer alias found:" << *BaseValue << "\nAS:\n" << AS);
-
-    // STATSCOP triggers an assertion if we are in verifying mode.
-    // This is generally good to check that we do not change the SCoP after we
-    // run the SCoP detection and consequently to ensure that we can still
-    // represent that SCoP. However, in case of aliasing this does not work.
-    // The independent blocks pass may create memory references which seem to
-    // alias, if -basicaa is not available. They actually do not. As we do not
-    // not know this and we would fail here if we verify it.
-    if (!Context.Verifying) {
-      STATSCOP(Alias);
-    }
-
-    return false;
-  }
+  if (!AS.isMustAlias())
+    INVALID(Alias, "Possible aliasing found for value: " << *BaseValue);
 
   return true;
 }