[llvm-commits] MachOObjectFile fix functions

[Owen Anderson]

Hey Danil,

Glad to see we're converging on something everyone likes.

On Nov 9, 2011, at 2:41 PM, Danil Malyshev wrote: 
> The symbol iterator iterate all symbols from all sections, so it make sense if symbol.getOffset() will returns the file offset. But we get relocations only for selected section, so relocation.getOffset() should return offset from this section. In addition we can get section virtual address or section offset one time and use it for each relocation in this section.

I see your reasoning here, but it scares me a little bit to have methods with the same name that do different things.  I think we should either rename them to be obviously different, or pick a consistent meaning for all of them.

--Owen

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20111109/fb017e2c/attachment.html>