[llvm-commits] AVX1 Code Generation - VSHUFP extension

[Bruno Cardoso Lopes]

Hi,

> I fixed the comments, I put 2 functions isCommutedVSHUFP() together.
>
> If this patch is good, please commit it.

Looks great! Just one more fix:

+static void CommuteVectorShuffleMask(SmallVectorImpl<int> &Mask, EVT VT);
+
+
+
+/// isCommutedVSHUFP() - Return true if swapping operands will
+///  allow to use the "vshufpd" or "vshufps" instruction
+///  for 256-bit vectors
+
+static bool isCommutedVSHUFPMask(const SmallVectorImpl<int> &Mask, EVT VT,
+                               const X86Subtarget *Subtarget) {

Please move the function definition up so you don't need to use a
declaration, and make the
comment above tied to the function (no newline between them).

-- 
Bruno Cardoso Lopes
http://www.brunocardoso.cc