[llvm-commits] [llvm] r144034 - in /llvm/trunk: lib/CodeGen/SelectionDAG/LegalizeDAG.cpp test/CodeGen/X86/2011-11-07-LegalizeBuildVector.ll

[Eli Friedman]

On Tue, Nov 8, 2011 at 10:17 AM, Chris Lattner <clattner at apple.com> wrote:
>
> On Nov 7, 2011, at 2:51 PM, Eli Friedman wrote:
>
>> Author: efriedma
>> Date: Mon Nov  7 16:51:10 2011
>> New Revision: 144034
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=144034&view=rev
>> Log:
>> Add a bunch of calls to RemoveDeadNode in LegalizeDAG, so legalization doesn't get confused by CSE later on.  Fixes PR11318.
>
> Should there be a new SelectionDAG method that does both RAUW + RemoveDeadNode's?  Should RAUW itself do this?

It looks like all the users of RAUW subsequently delete the node in question.

I just noticed, though, that apparently we don't generally guarantee
that a node will have no uses after a RAUW.  So some additional
changes might be necessary here anyway.

-Eli