[llvm-commits] [llvm] r143641 - /llvm/trunk/utils/llvm-build/llvmbuild/main.py

[Daniel Dunbar]

Author: ddunbar
Date: Thu Nov  3 14:45:52 2011
New Revision: 143641

URL: http://llvm.org/viewvc/llvm-project?rev=143641&view=rev
Log:
llvm-build: Avoid followlinks keyword argument to os.walk.
 - llvm-build should now be Python2.4 compatible as best I know.

Modified:
    llvm/trunk/utils/llvm-build/llvmbuild/main.py

Modified: llvm/trunk/utils/llvm-build/llvmbuild/main.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/llvm-build/llvmbuild/main.py?rev=143641&r1=143640&r2=143641&view=diff
==============================================================================
--- llvm/trunk/utils/llvm-build/llvmbuild/main.py (original)
+++ llvm/trunk/utils/llvm-build/llvmbuild/main.py Thu Nov  3 14:45:52 2011
@@ -14,8 +14,13 @@
         # directories we have already traversed.
 
         # First, discover all the LLVMBuild.txt files.
-        for dirpath,dirnames,filenames in os.walk(llvmbuild_source_root,
-                                                  followlinks = True):
+        #
+        # FIXME: We would like to use followlinks=True here, but that isn't
+        # compatible with Python 2.4. Instead, we will either have to special
+        # case projects we would expect to possibly be linked to, or implement
+        # our own walk that can follow links. For now, it doesn't matter since
+        # we haven't picked up the LLVMBuild system in any other LLVM projects.
+        for dirpath,dirnames,filenames in os.walk(llvmbuild_source_root):
             # If there is no LLVMBuild.txt file in a directory, we don't recurse
             # past it. This is a simple way to prune our search, although it
             # makes it easy for users to add LLVMBuild.txt files in places they