[llvm-commits] [llvm] r141286 - in /llvm/trunk: bindings/ocaml/llvm/llvm.ml bindings/ocaml/llvm/llvm.mli bindings/ocaml/llvm/llvm_ocaml.c include/llvm-c/Core.h lib/VMCore/Core.cpp

[Tobias Grosser]

On 10/06/2011 01:13 PM, Torok Edwin wrote:
> Author: edwin
> Date: Thu Oct  6 07:13:11 2011
> New Revision: 141286
>
> URL: http://llvm.org/viewvc/llvm-project?rev=141286&view=rev
> Log:
> ocaml/C bindings: getmdstring, add num_op, get_op should work on metadata too
>
> ==============================================================================
> --- llvm/trunk/include/llvm-c/Core.h (original)
> +++ llvm/trunk/include/llvm-c/Core.h Thu Oct  6 07:13:11 2011
> @@ -550,6 +550,11 @@
>   LLVMValueRef LLVMMDNodeInContext(LLVMContextRef C, LLVMValueRef *Vals,
>                                    unsigned Count);
>   LLVMValueRef LLVMMDNode(LLVMValueRef *Vals, unsigned Count);
> +const char  *LLVMGetMDString(LLVMValueRef V, unsigned* Len);
> +int LLVMGetMDNodeNumOperands(LLVMValueRef V);
> +LLVMValueRef *LLVMGetMDNodeOperand(LLVMValueRef V, unsigned i);

Hi,

I just realized that you never introduced an implementation for the
last two function declarations. Did you forget about them or are you 
planning to use them soon. In case you do not, what about removing them
from the header file?

Tobi