[llvm-commits] patch: don't emit a directory entry for DW_at_comp_dir

[Nick Lewycky]

On 21 October 2011 14:11, Nick Lewycky <nlewycky at google.com> wrote:

> On 18 October 2011 15:53, Nick Lewycky <nlewycky at google.com> wrote:
>
>> In DWARF, the file table contains indices back into the directory table.
>> As an optimization, directory entry zero is assumed to refer to the value
>> in DW_at_comp_dir. Don't emit two copies of that string!
>>
>> Please review!
>>
>
> Ping!
> http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20111017/130273.html
>
> I know Eric started looking at this and was hoping it's be possible to do
> in a different, cleaner way. I'd be happy to change how it works if anyone
> has a proposal. As it stands right now, we assume that a blank directory
> entry means "use directory entry zero" which is what GNU as and llvm-mc
> have always done. This patch causes us to emit ".file index filename" with
> no directory part when the directory is equal to the comp_dir.
>

Updated patch. Renamed "DirIndexZero" to "CompilationDir" and added another
test. Please review!

Nick
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20111101/280ad477/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dwarf-dir-table.patch
Type: text/x-patch
Size: 3551 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20111101/280ad477/attachment.bin>