[llvm-commits] [llvm] r141977 - /llvm/trunk/utils/llvmbuild

[Daniel Dunbar]

Hi David,

This script appears to be pretty specific to your workflow. While it
looks cool, I'm not really sure it belongs where it is.

I also want to take the llvm-build name, and I don't want people to be
confused by two similarly but completely unrelated things.

Do you really feel like this script is something that belongs in the
tree? Does anyone else use it?

Are you ok moving it aside and to a name that is more specific to what
it does, instead of a the very generic llvmbuild name?

 - Daniel

On Fri, Oct 14, 2011 at 12:12 PM, David Greene <greened at obbligato.org> wrote:
> Author: greened
> Date: Fri Oct 14 14:12:37 2011
> New Revision: 141977
>
> URL: http://llvm.org/viewvc/llvm-project?rev=141977&view=rev
> Log:
> Fix threads/jobs Calculation
>
> Pass the correct jobs and threads information to the builder.
> We were underutilizing the number of jobs and threads specified
> by the user.
>
> Modified:
>    llvm/trunk/utils/llvmbuild
>
> Modified: llvm/trunk/utils/llvmbuild
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/llvmbuild?rev=141977&r1=141976&r2=141977&view=diff
> ==============================================================================
> --- llvm/trunk/utils/llvmbuild (original)
> +++ llvm/trunk/utils/llvmbuild Fri Oct 14 14:12:37 2011
> @@ -755,9 +755,10 @@
>     jobs = 1
>
>  numthreads = options.threads
> -if jobs < numthreads:
> -    numthreads = jobs
> -    jobs = 1
> +
> +logging.getLogger().info("Building with " + str(options.jobs) + " jobs and "
> +                         + str(numthreads) + " threads using " + str(jobs)
> +                         + " make jobs")
>
>  for t in range(numthreads):
>     builder = Builder(work_queue, jobs,
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>